-
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: The Scrollbar's ScrollController has no ScrollPosition attached
#3808
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3808 +/- ##
===========================================
- Coverage 10.67% 10.67% -0.01%
===========================================
Files 272 272
Lines 13547 13548 +1
===========================================
Hits 1446 1446
- Misses 12101 12102 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
The Scrollbar's ScrollController has no ScrollPosition attached
The Scrollbar's ScrollController has no ScrollPosition attached
The Scrollbar's ScrollController has no ScrollPosition attached
The Scrollbar's ScrollController has no ScrollPosition attached
child: PrimaryScrollController( | ||
controller: _controller, | ||
child: Scrollbar( | ||
child: ListView( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
child: PrimaryScrollController( | |
controller: _controller, | |
child: Scrollbar( | |
child: ListView( | |
child: ListView( | |
controller: _controller, |
Just curious: could you try this instead? That would look much easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious: could you try this instead? That would look much easier.
@g123k ping
It should be a quick test and if it's not successful I'll quickly approve the current PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops didn't saw your comment.
Basically it will do the same, by inheriting from it, it think it's better as it allows to use a different one in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really have a preference for the simple syntax if it does exactly the same.
And I would let the future developers worry about using a different syntax only if they need it.
Honestly, it's just an error in the console, so let's merge this. |
The
Scrollbar
in the Edit product page doesn't have a Controller attached, but only theListView
below.It will fix #3807