fix: The Scrollbar's ScrollController has no ScrollPosition attached
#3808
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3808 +/- ##
===========================================
- Coverage 10.67% 10.67% -0.01%
===========================================
Files 272 272
Lines 13547 13548 +1
===========================================
Hits 1446 1446
- Misses 12101 12102 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
g123k
changed the title
The Scrollbar's ScrollController has no ScrollPosition attachedThe Scrollbar's ScrollController has no ScrollPosition attached
g123k
changed the title
The Scrollbar's ScrollController has no ScrollPosition attachedThe Scrollbar's ScrollController has no ScrollPosition attached
| child: PrimaryScrollController( | ||
| controller: _controller, | ||
| child: Scrollbar( | ||
| child: ListView( |
There was a problem hiding this comment.
| child: PrimaryScrollController( | |
| controller: _controller, | |
| child: Scrollbar( | |
| child: ListView( | |
| child: ListView( | |
| controller: _controller, |
Just curious: could you try this instead? That would look much easier.
There was a problem hiding this comment.
Just curious: could you try this instead? That would look much easier.
@g123k ping
It should be a quick test and if it's not successful I'll quickly approve the current PR.
There was a problem hiding this comment.
Oops didn't saw your comment.
Basically it will do the same, by inheriting from it, it think it's better as it allows to use a different one in the future
There was a problem hiding this comment.
I really have a preference for the simple syntax if it does exactly the same.
And I would let the future developers worry about using a different syntax only if they need it.
|
Honestly, it's just an error in the console, so let's merge this. |
The
Scrollbarin the Edit product page doesn't have a Controller attached, but only theListViewbelow.It will fix #3807