-
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add rate the app link and share the app link in the settings page! #3704
Conversation
height: DEFAULT_ICON_SIZE, | ||
width: DEFAULT_ICON_SIZE, | ||
child: Image.asset(Platform.isIOS | ||
? 'assets/app/app-store.png' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be easier with SVG for size concerns
ListTile( | ||
leading: const Icon(Icons.share), | ||
title: const Text( | ||
'Share Open Food Facts', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
string to extract
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I remove it, or should we add it here also ! There was a picture in the issue #2551 ,.i saw that and did this 😄.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @teolemon means with extract to put it into app_en.arb
]; | ||
} | ||
|
||
class _RateUs extends StatelessWidget { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it conditional to the flavor ? We also build for fdroid, fyi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will check that ,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain a bit more about "is it conditional to the flavor"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this also works with F-Droid and I think it does not
You can get the flavour using the global variable flavour
(main.dart l.54) can be used everywhere in the code.
Or even better await ApplicationStore.openAppReview()
we already have this function implemented, this way you don't even have to worry about this and we don't need store_redirect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh coooll I will look into it and make changes !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have a "Share Open Food Facts button" in Contribute
Oh okay !! I will remove that ! |
- use preDEfined share button - remove store_redirect
f8703cf
to
8fdecdb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @Sudhanva-Nadiger, looking forward to more reviews 😄
What
Screenshot
redirect.mp4
Fixes bug(s)
Part of