feat: add rate the app link and share the app link in the settings page! #3704
Conversation
| height: DEFAULT_ICON_SIZE, | ||
| width: DEFAULT_ICON_SIZE, | ||
| child: Image.asset(Platform.isIOS | ||
| ? 'assets/app/app-store.png' |
There was a problem hiding this comment.
I'd be easier with SVG for size concerns
| ListTile( | ||
| leading: const Icon(Icons.share), | ||
| title: const Text( | ||
| 'Share Open Food Facts', |
| ]; | ||
| } | ||
|
|
||
| class _RateUs extends StatelessWidget { |
There was a problem hiding this comment.
is it conditional to the flavor ? We also build for fdroid, fyi
There was a problem hiding this comment.
I will check that ,
There was a problem hiding this comment.
Can you explain a bit more about "is it conditional to the flavor"?
There was a problem hiding this comment.
If this also works with F-Droid and I think it does not
You can get the flavour using the global variable flavour (main.dart l.54) can be used everywhere in the code.
Or even better await ApplicationStore.openAppReview() we already have this function implemented, this way you don't even have to worry about this and we don't need store_redirect
There was a problem hiding this comment.
Oh coooll I will look into it and make changes !
|
Oh okay !! I will remove that ! |
- use preDEfined share button - remove store_redirect
Sudhanva-Nadiger
requested review from
M123-dev and
teolemon
and removed request for
M123-dev and
teolemon
Sudhanva-Nadiger
force-pushed
the
redirect
branch
from
f8703cf
to
8fdecdb
Compare
Sudhanva-Nadiger
requested review from
teolemon
and removed request for
M123-dev
There was a problem hiding this comment.
Looks great, thanks @Sudhanva-Nadiger, looking forward to more reviews 😄
What
Screenshot
redirect.mp4
Fixes bug(s)
Part of