feat: added feedback form links #3487
Conversation
|
I was thinking to put all the links into a constant file, or should it same? |
Codecov Report
@@ Coverage Diff @@
## develop #3487 +/- ##
========================================
Coverage 11.08% 11.08%
========================================
Files 263 264 +1
Lines 13089 13086 -3
========================================
Hits 1451 1451
+ Misses 11638 11635 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@M123-dev any update on this? |
I would too. Maybe extracting the function that generates the url and then calling it where needed would be the best solution. |
|
yes that sounds like a good idea |
|
Yes sounds good. For other links we have put them in the translation files because the link was translated completely true. For this I'm also a fan of just storing them in the code |
| static String getFeedbackFormLink() { | ||
| final String languageCode = ProductQuery.getLanguage().code; | ||
| if (languageCode == 'en') { | ||
| return 'https://forms.gle/AuNZG6fXyAPqN5tL7'; | ||
| } else if (languageCode == 'de') { | ||
| return 'https://forms.gle/vCurhD2Y3ewS1YPv5'; | ||
| } else if (languageCode == 'es') { | ||
| return 'https://forms.gle/CSMmuzR8i4LJBjbM9'; | ||
| } else if (languageCode == 'fr') { | ||
| return 'https://forms.gle/cTR4wqGmW7pGUiaBA'; | ||
| } else if (languageCode == 'it') { | ||
| return 'https://forms.gle/9HcCLFznym1ByQgB6'; | ||
| } else { | ||
| return 'https://forms.gle/AuNZG6fXyAPqN5tL7'; | ||
| } | ||
| } |
There was a problem hiding this comment.
Heyy @Omegaviv these changes look good, could we only move the getFeedbackFormLink method, currently it's in the haptic feedback helper, though this is only meant for vibrations not for "real" feedback.
You could create a new UserFeedbackHelper clas in a new lib/helpers/user_feedback_helper.dart file
|
There were some import problems due to changes on the master branch, fixes them |
Add a feedback form in case the user says (s)he doesn't like the app #3419
Screenshot