chore: Add dev mode setting to add cards to the scanner #3400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monsieurtanuki
approved these changes
Dec 2, 2022
There was a problem hiding this comment.
That's a good idea @M123-dev!
Regarding the unrelated .cc or .swift files I would have put them in a separate "chore" PR, but that's OK I guess.
| @@ -321,6 +322,23 @@ class UserPreferencesDevMode extends AbstractUserPreferences { | |||
| localDatabase.notifyListeners(); | |||
| }, | |||
| ), | |||
| ListTile( | |||
| title: const Text('Add cards to scanner'), | |||
| subtitle: const Text('Adds 4 sample products to the scanner'), | |||
There was a problem hiding this comment.
It's probably 3 instead of 4.
M123-dev
commented
Dec 2, 2022
packages/smooth_app/lib/pages/preferences/user_preferences_dev_mode.dart
Outdated
Show resolved
Hide resolved
|
Thanks for the review @monsieurtanuki |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds a new option to the dev mode to add cards to the scanner. This allows better testing when using an emulator. I can't scan on it. In this go I removed the barcode trust check. Correct me if I'm wrong but it had no purpose anymore
+ a lot of generated changes