Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added auto complete text field for origins #3209 #3230

Merged

Conversation

AshAman999
Copy link
Member

@AshAman999 AshAman999 commented Oct 29, 2022

What

  • auto-complete for origins field

Screenshot

image

Fixes bug(s)

@AshAman999
Copy link
Member Author

packages\smooth_app\lib\query\product_query.dart

image

@monsieurtanuki
I was not sure about what to replace with here ,

@AshAman999 AshAman999 changed the title fix: added auto completed for origins #3209 fix: added auto complete text field for origins #3209 Oct 29, 2022
@monsieurtanuki
Copy link
Contributor

packages\smooth_app\lib\query\product_query.dart
@monsieurtanuki I was not sure about what to replace with here ,

Just remove the ENVIRONMENT fields, they are not populated anymore and we don't use them in Smoothie anyway.
And the suggested ECOSCORE fields are already in ProductQuery.

Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AshAman999 Perfect, I'm glad the fix is so easy!

@codecov-commenter
Copy link

Codecov Report

Merging #3230 (c1b7752) into develop (d7fa70d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #3230   +/-   ##
=======================================
  Coverage     7.69%   7.69%           
=======================================
  Files          249     249           
  Lines        12248   12248           
=======================================
  Hits           942     942           
  Misses       11306   11306           
Impacted Files Coverage Δ
...p/lib/pages/product/simple_input_page_helpers.dart 0.00% <ø> (ø)
packages/smooth_app/lib/query/product_query.dart 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AshAman999 AshAman999 merged commit a3608be into openfoodfacts:develop Oct 29, 2022
@M123-dev M123-dev added this to the v4 milestone Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We need autocomplete for the origin field
4 participants