Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: back button invisible for some preferences' screen #2760

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Aug 9, 2022

The back button is visible again 🥳
Screenshot_1660022798

Fix #2756

@g123k g123k self-assigned this Aug 9, 2022
@g123k g123k requested a review from a team as a code owner August 9, 2022 05:31
@codecov-commenter
Copy link

Codecov Report

Merging #2760 (d75bf26) into develop (2ea0da3) will decrease coverage by 1.69%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #2760      +/-   ##
==========================================
- Coverage     8.86%   7.16%   -1.70%     
==========================================
  Files          161     218      +57     
  Lines         6623   10565    +3942     
==========================================
+ Hits           587     757     +170     
- Misses        6036    9808    +3772     
Impacted Files Coverage Δ
...kages/smooth_app/lib/widgets/attribute_button.dart 0.00% <0.00%> (-92.00%) ⬇️
...s/smooth_app/lib/data_models/user_preferences.dart 8.73% <0.00%> (-23.57%) ⬇️
packages/smooth_app/lib/themes/smooth_theme.dart 62.26% <0.00%> (-20.72%) ⬇️
...p/lib/generic_lib/dialogs/smooth_alert_dialog.dart 15.11% <0.00%> (-19.10%) ⬇️
...mooth_app/lib/data_models/product_preferences.dart 21.68% <0.00%> (-9.75%) ⬇️
packages/smooth_app/lib/main.dart 14.65% <0.00%> (-3.24%) ⬇️
.../smooth_app/lib/pages/onboarding/welcome_page.dart 0.00% <0.00%> (-3.13%) ⬇️
.../smooth_app/lib/pages/onboarding/scan_example.dart 0.00% <0.00%> (-2.28%) ⬇️
...p/lib/pages/onboarding/consent_analytics_page.dart 0.00% <0.00%> (-1.57%) ⬇️
...ackages/smooth_app/lib/pages/scan/scan_header.dart 3.33% <0.00%> (-1.43%) ⬇️
... and 237 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @g123k

@M123-dev M123-dev merged commit e58db02 into openfoodfacts:develop Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is back button gone? 🤨
3 participants