-
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Edit product page UI improvements #2754
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2754 +/- ##
==========================================
- Coverage 8.86% 7.13% -1.73%
==========================================
Files 161 218 +57
Lines 6623 10604 +3981
==========================================
+ Hits 587 757 +170
- Misses 6036 9847 +3811
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
maxLines: _barcodeVisibleInAppbar ? 1 : 2, | ||
), | ||
if (_product.barcode?.isNotEmpty == true) | ||
Visibility( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about using AnimatedSwitcher
instead of the Visibility
widget? It should make the transition animated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the title can initially be on two lines, the rendering is not well appealed.
A custom one is required here. We should maybe implement it later?
@g123k needs rebase before merging |
46a03d3
to
ef97166
Compare
Should be OK now 👌 |
untitled.mp4