feat: 785 - list of problematic attributes as score explanation #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `api_matched_product_v1_test.dart`: minor refactoring * `api_matched_product_v2_test.dart`: added a test about score explanations * `api_product_preferences_test.dart`: minor refactoring * `available_attribute_groups.dart`: refactored with language instead of language code * `available_preference_importances.dart`: refactored with language instead of language code * `matched_product_v2.dart`: added an optional parameter that lists the problematic attributes when the status unknown, does not match and may not match
Codecov Report
@@ Coverage Diff @@
## master #786 +/- ##
==========================================
+ Coverage 73.00% 73.07% +0.06%
==========================================
Files 203 203
Lines 7417 7472 +55
==========================================
+ Hits 5415 5460 +45
- Misses 2002 2012 +10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Just curious: where will those explanations be displayed? |
|
I guess we would be better off trying to code it directly in Smoothie with incremental changes, and different UI/UX. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
'Caractère végétarien inconnu'(FR) /'Vegetarian status unknown'(EN).Fixes bug(s)
Part of
Impacted files
api_matched_product_v1_test.dart: minor refactoringapi_matched_product_v2_test.dart: added a test about score explanationsapi_product_preferences_test.dart: minor refactoringavailable_attribute_groups.dart: refactored with language instead of language codeavailable_preference_importances.dart: refactored with language instead of language codematched_product_v2.dart: added an optional parameter that lists the problematic attributes when the status unknown, does not match and may not match