Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug in clone logic #1155

Open
nikhilwoodruff opened this issue Oct 19, 2022 · 2 comments
Open

Possible bug in clone logic #1155

nikhilwoodruff opened this issue Oct 19, 2022 · 2 comments
Labels
kind:bug Bugs are defects and failure demand. level:advanced Requires substantial OpenFisca experience

Comments

@nikhilwoodruff
Copy link
Contributor

Sometimes when cloning a simulation, I've found that the original simulation is inexplicably affected by actions in the cloned simulation. I've seen this for a while but have been unable to generate a MWE, but yesterday I think I found the issue, in this line. When a group population is cloned, it looks like the clone still has access to the original members, which is unchanged.

@benjello benjello added level:advanced Requires substantial OpenFisca experience kind:bug Bugs are defects and failure demand. labels Oct 19, 2022
@bonjourmauko
Copy link
Member

Thanks @nikhilwoodruff .

@benjello at first I thought this was a duplicate of #848 , yet reading both issues, it appears like the behaviour described here is intended. Do you confirm?

@benjello
Copy link
Member

benjello commented Dec 7, 2022

I think the behaviour expected by @nikhilwoodruff should be enforced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug Bugs are defects and failure demand. level:advanced Requires substantial OpenFisca experience
Projects
None yet
Development

No branches or pull requests

3 participants