-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.8 #1168
base: master
Are you sure you want to change the base?
Conversation
c368d4a
to
addb116
Compare
Co-authored-by: Matti Schneider <matti.schneider@openfisca.fr>
ab7d424
to
51272ee
Compare
Hi @MattiSG, please let me know if you're OK with these changes. I removed the web triggered part to reduce scope. |
on: | ||
pull_request: | ||
types: [assigned, opened, reopened, synchronize, ready_for_review] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this PR, the CI will not run on push outside a Pull Request.
Curent behavior is to run on all push : on: [ push, pull_request, workflow_dispatch ]
.
See also : openfisca/openfisca-france#1788 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I removed it to easy review. But I can readd it. I'll do.
strategy: | ||
fail-fast: true | ||
matrix: | ||
os: [ubuntu-20.04, windows-latest] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment to explain why you use old ubuntu-20.04 instead of ubuntu-22.04 ?
Because the Python version between Windows-latest and Ubuntu 22.04 did not match, cf https://github.com/raw/actions/python-versions/main/versions-manifest.json ?
See my failing test on https://github.com/openfisca/openfisca-core/actions/runs/4015575836
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in the time between this PR was open Github also updated windows.
Fixes #1035
Fixes #1153
Fixes #1058
Fixes #1111
Breaking changes
New features