Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release contains [dev] extra requires #1121

Open
MattiSG opened this issue Apr 25, 2022 · 2 comments
Open

Release contains [dev] extra requires #1121

MattiSG opened this issue Apr 25, 2022 · 2 comments

Comments

@MattiSG
Copy link
Member

MattiSG commented Apr 25, 2022

Hi there!

I really enjoy OpenFisca, but I recently encountered an issue.

Here is what I did:

make build

Here is what I expected to happen:

The resulting wheel file contains the production dependencies.

Here is what actually happened:

The resulting wheel file contains the [dev] extra requires.

Context

I identify more as a:

  • Developer (I create tools that use the existing OpenFisca code).
@bonjourmauko
Copy link
Member

Hello @MattiSG !

I suspect this is because of the following line:

@find dist -name "*.whl" -exec pip install {}[dev] \;

There's a pull request open that solves this issue #1058

@MattiSG
Copy link
Member Author

MattiSG commented Dec 13, 2022

Thanks @maukoquiroga for the pointer!
#1058 has been closed and superseded by #1068, and #1068 indeed replaces the provided line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants