Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for OEP-12 #44

Merged
merged 1 commit into from
Jan 26, 2017
Merged

Fixes for OEP-12 #44

merged 1 commit into from
Jan 26, 2017

Conversation

andy-armstrong
Copy link
Contributor

@andy-armstrong andy-armstrong commented Jan 25, 2017

This fixes a few stylistic issues with the documentation for OEP-12:

  • add missing image
  • fix broken image link
  • fix broken enumerated list
  • fix broken bulleted list

@cahrens
Copy link
Contributor

cahrens commented Jan 25, 2017

@andy-armstrong this doesn't look correct.

image

 - add missing image
 - fix broken image link
 - fix broken enumerated list
@andy-armstrong
Copy link
Contributor Author

@cahrens great catch. I've pushed up a (squashed) fix for that too.

@clintonb
Copy link

@efagin @cpennington who controls the RTD account for this repo? It would be ideal if we built PR branches so we can catch RST formatting issues before they are merged.

@andy-armstrong andy-armstrong merged commit e12b826 into master Jan 26, 2017
@andy-armstrong andy-armstrong deleted the andya/oep-12-fixes branch January 26, 2017 00:05
@andy-armstrong
Copy link
Contributor Author

Great point, @clintonb. I considered building it locally but didn't get around to it.

BTW, RTD regenerated and the issues all look resolved now. Hopefully I won't need a second follow-up!

http://open-edx-proposals.readthedocs.io/en/latest/oep-0012.html

@cpennington
Copy link
Contributor

@clintonb: I have management rights (as does the shared edx account, I believe). That said, I don't think RTD has a feature for automatically building PRs (readthedocs/readthedocs.org#2465), so we'd need to build them manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants