Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(operator): use a common label (jivaAPI) to reference jiva api #171

Conversation

abhisheksinghbaghel
Copy link
Contributor

@abhisheksinghbaghel abhisheksinghbaghel commented Dec 8, 2021

resolves #169

Signed-off-by: Abhishek Singh Baghel abhib@microsoft.com

Why is this PR required? What issue does it fix?:
_Fixes #169

What this PR does?:
Updates code base to use jivaAPI as a common label to reference "github.com/openebs/jiva-operator/pkg/apis/openebs/v1"

Does this PR require any upgrade changes?:
No

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • PR Title follows the convention of <type>(<scope>): <subject>.
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Does this PR change require updating Helm Chart? If yes, mention the Helm Chart PR #
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue https://github.com/openebs/website is used to track them:

Copy link
Contributor

@shubham14bajpai shubham14bajpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @abhisheksinghbaghel Thank you for the PR. Just a few nit comments

cmd/manager/main.go Outdated Show resolved Hide resolved
pkg/client/clientset/versioned/fake/register.go Outdated Show resolved Hide resolved
resolves openebs-archive#169

Signed-off-by: Abhishek Singh Baghel <abhib@microsoft.com>
@abhisheksinghbaghel abhisheksinghbaghel changed the title refactor(operator): use a common label (jivaapi) to reference jiva api refactor(operator): use a common label (jivaAPI) to reference jiva api Dec 8, 2021
Copy link
Contributor

@shubham14bajpai shubham14bajpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shubham14bajpai shubham14bajpai merged commit 3bd622d into openebs-archive:develop Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: use a common label to refer to jiva api.
2 participants