fix(helm): Make log verbosity configurable #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianroberts
force-pushed
the
log-level
branch
2 times, most recently
from
2d86d4d
to
f22ec85
Compare
Make log verbosity level configurable via chart values, rather than hard-coding --v=5 (the most verbose level, intended for trace-level logging). For backwards compatibility the defaults are still set to "5" everywhere, but this can now be overridden via csiController.{attacher|provisioner|resizer}.logLevel for the controller (or csiController.logLevel to set all three at once) and csiNode.driverRegistrar.logLevel for the CSI node.
Signed-off-by: Ian Roberts <i.roberts@dcs.shef.ac.uk>
|
Bumped chart version to fix lint failure |
There was a problem hiding this comment.
good one @ianroberts , can you pls do the similar changes in cstor-operator helm chart as well
Co-authored-by: Prateek Pandey <prateekpandey14@gmail.com>
|
prateekpandey14
approved these changes
Oct 19, 2021
ianroberts
added a commit
to ianroberts/jiva-operator
that referenced
this pull request
Oct 27, 2021
This is a modification to openebs-archive#161 to reverse the order of the overriding between csiController.logLevel and csiController.<container>.logLevel following discussions on openebs-archive/cstor-operators#397. Now csiController.logLevel sets a default at the pod level, and csiController.*.logLevel overrides that default for the relevant pod. Signed-off-by: Ian Roberts <i.roberts@dcs.shef.ac.uk>
4 tasks
mittachaitu
pushed a commit
that referenced
this pull request
Nov 25, 2021
This is a modification to #161 to reverse the order of the overriding between csiController.logLevel and csiController.<container>.logLevel following discussions on openebs-archive/cstor-operators#397. Now csiController.logLevel sets a default at the pod level, and csiController.*.logLevel overrides that default for the relevant pod. Signed-off-by: Ian Roberts <i.roberts@dcs.shef.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR required? What issue does it fix?:
At present, when installing via the helm charts a number of containers produce overly-verbose logging, in particular the
csi-controllerlogs a "successfully renewed lease" message every five seconds continuously.What this PR does?:
Various containers are hard-coded in the Helm chart to run with trace-level logging enabled (
--v=5), this PR makes these configurable via the values file/--set. To maintain backwards compatibility the defaults invalues.yamlremain at--v=5(whether this should change is a separate discussion...) but they can now be overridden viacsiController.logLevelto change all the CSI controller containers to the same level in one go. If this value is not set then we fall back to per-container settings, all of which default to "5"csiController.attacher.logLevelcsiController.provisioner.logLevelcsiController.resizer.logLevelcsiNode.logLevelas above for the CSI node pod, though there is only one container-specific child value in this case:csiNode.driverRegistrar.logLevelfor the node pod driver registrarDoes this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Checklist:
<type>(<scope>): <subject>.