Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devFlags should not default to empty objects #655

Closed
strangiato opened this issue Oct 20, 2023 · 1 comment · Fixed by #659
Closed

devFlags should not default to empty objects #655

strangiato opened this issue Oct 20, 2023 · 1 comment · Fixed by #659
Assignees
Labels
enhancement New feature or request rhods-2.6

Comments

@strangiato
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When creating a new DSC such as the following:

apiVersion: datasciencecluster.opendatahub.io/v1
kind: DataScienceCluster
metadata:
  name: default
spec:
  components:
    codeflare:
      managementState: Removed
    dashboard:
      managementState: Managed
    datasciencepipelines:
      managementState: Managed
    kserve:
      managementState: Removed
    modelmeshserving:
      managementState: Managed
    ray:
      managementState: Removed
    workbenches:
      managementState: Managed

After the object is created, the operator automatically adds the devFlags as an empty object for all components:

apiVersion: datasciencecluster.opendatahub.io/v1
kind: DataScienceCluster
metadata:
  name: default
spec:
  components:
    codeflare:
      devFlags: {}
      managementState: Removed
    dashboard:
      devFlags: {}
      managementState: Managed
    datasciencepipelines:
      devFlags: {}
      managementState: Managed
    kserve:
      devFlags: {}
      managementState: Removed
    modelmeshserving:
      devFlags: {}
      managementState: Managed
    ray:
      devFlags: {}
      managementState: Removed
    workbenches:
      devFlags: {}
      managementState: Managed

Describe the solution you'd like
devFlags should not default to empty objects when none is provided. They should only appear when the option is provided by a user.

Describe alternatives you've considered

Additional context
devFlags are not a feature that will ever be allowed on a supported version of a DSC and are an advanced feature only intended to be used in testing scenarios. They should not be present in most systems and should not be defaulted.

@strangiato strangiato added the enhancement New feature or request label Oct 20, 2023
@AjayJagan AjayJagan self-assigned this Oct 23, 2023
@AjayJagan AjayJagan linked a pull request Oct 24, 2023 that will close this issue
3 tasks
@zdtsw zdtsw added rhods-2.6 and removed rhods-2.5 labels Nov 22, 2023
@AjayJagan
Copy link
Contributor

Migrated to JIRA: https://issues.redhat.com/browse/RHOAIENG-487, hence closing it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rhods-2.6
Projects
Status: Done
Status: No status
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants