Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cubedash_hide_products_by_name_list config #408

Merged
merged 3 commits into from
Jul 15, 2022
Merged

Conversation

pindge
Copy link
Collaborator

@pindge pindge commented Jul 11, 2022

Fixes #404

Scope:

changes to /audit/dataset-counts and /audit/storage pages

  • pages will only display non-hidden products but all products are available for downloading

image
image

Changes to /products page

  • only displaying non-hidden products, but all products are still available from text, stac and yaml download

image

Changes to products top bar menu

  • the top bar products drop-down menu is the only UI component with access to hidden products, hidden products are not accessible from the product selection by date menu

image
image

@pindge pindge added the UI/UX User interface issues label Jul 11, 2022
@pindge pindge requested review from jeremyh and omad July 11, 2022 23:30
@robbibt
Copy link

robbibt commented Jul 11, 2022

Hey Pin, this sounds great. Some quick comments:

  • The text above uses "Total indexed products" vs. "Total products" (different text), and "hidden products" vs. "Hidden products" (different capitalisation). Would be nice to keep this consistent, e.g. just use "Total products: X, hidden products: X" everwhere
  • I think CSV should be capitalised, e.g. "Download CSV ..."
  • I think "Download csv for all products dataset count" should be "Download CSV for all product dataset counts" and "Download csv for all products locations" should be "Download csv for all product locations" (also, are "counts" and "locations" what we currently call "regions" and "footprints" on Explorer?)

@pindge
Copy link
Collaborator Author

pindge commented Jul 12, 2022

Hey Pin, this sounds great. Some quick comments:

  • The text above uses "Total indexed products" vs. "Total products" (different text), and "hidden products" vs. "Hidden products" (different capitalisation). Would be nice to keep this consistent, e.g. just use "Total products: X, hidden products: X" everwhere
  • I think CSV should be capitalised, e.g. "Download CSV ..."
  • I think "Download csv for all products dataset count" should be "Download CSV for all product dataset counts" and "Download csv for all products locations" should be "Download csv for all product locations" (also, are "counts" and "locations" what we currently call "regions" and "footprints" on Explorer?)

the product location is the storage page https://explorer.dev.dea.ga.gov.au/audit/storage

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #408 (56bca96) into develop (9c1730e) will not change coverage.
The diff coverage is n/a.

❗ Current head 56bca96 differs from pull request most recent head 3a21781. Consider uploading reports for the commit 3a21781 to get more accurate results

@@           Coverage Diff            @@
##           develop     #408   +/-   ##
========================================
  Coverage    86.92%   86.92%           
========================================
  Files           25       25           
  Lines         3158     3158           
========================================
  Hits          2745     2745           
  Misses         413      413           
Impacted Files Coverage Δ
cubedash/_pages.py 88.25% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c1730e...3a21781. Read the comment docs.

@pindge pindge requested a review from robbibt July 12, 2022 05:09
Copy link
Member

@omad omad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for including the screenshots!

@omad
Copy link
Member

omad commented Jul 14, 2022

image

@pindge pindge merged commit 8272f23 into develop Jul 15, 2022
@delete-merged-branch delete-merged-branch bot deleted the hide-products branch July 15, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI/UX User interface issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] add configurable hide product list which won't show up on product select list by default
3 participants