Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align datasets for high tide comp centre_dt 1995 to 2000 #382

Merged
merged 4 commits into from
Jun 2, 2022

Conversation

pindge
Copy link
Collaborator

@pindge pindge commented Jun 1, 2022

fixes #376

@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #382 (76272e6) into develop (a989a8e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #382   +/-   ##
========================================
  Coverage    86.41%   86.41%           
========================================
  Files           25       25           
  Lines         3121     3121           
========================================
  Hits          2697     2697           
  Misses         424      424           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a989a8e...76272e6. Read the comment docs.

@pindge pindge requested review from jeremyh and robbibt June 1, 2022 05:30
@jeremyh
Copy link
Collaborator

jeremyh commented Jun 1, 2022

This test data was dumped directly from our own (production) products. Have the original products changed?

Copy link

@robbibt robbibt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Pin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorrect integration test case for high_low_tide
3 participants