Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config-linux: Is syscalls really required? #762

Closed
wking opened this issue Apr 7, 2017 · 1 comment · Fixed by #768
Closed

config-linux: Is syscalls really required? #762

wking opened this issue Apr 7, 2017 · 1 comment · Fixed by #768

Comments

@wking
Copy link
Contributor

wking commented Apr 7, 2017

While reviewing our required/optional settings, I noticed that linux.seccomp.sycalls is required, but that we don't require an entry in the array. That means "syscalls": [] would be technically valid, and I'm pretty sure that's not what we want.

If it makes sense to have a seccomp property that does not need syscalls entries, then syscalls should be optional.

If it does not makes sense to have an empty/unset syscalls then it should be required and have a minimum length of one.

Before #657, syscalls was omitempty (and therefore more optional-feeling, although there was no real Markdown spec for seccomp before #706, so it's hard to know). My current impression is that the property should be optional (and get its old omitempty back), but I'm fine either way as long as we have a consistent position.

@wking
Copy link
Contributor Author

wking commented Apr 7, 2017

syscalls' names property is in the same boat. If names is required, I think we need to also require it to have a length ≥ 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant