Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(azure): remove locale from docs link #1054

Merged
merged 2 commits into from
Sep 11, 2024
Merged

docs(azure): remove locale from docs link #1054

merged 2 commits into from
Sep 11, 2024

Conversation

scottaddie
Copy link
Contributor

@scottaddie scottaddie commented Sep 10, 2024 •
edited
Loading

Remove "en-us" locale string from Learn link. The user's preferred locale should be honored, not overridden.

@scottaddie scottaddie requested a review from a team as a code owner September 10, 2024 21:31
@scottaddie scottaddie marked this pull request as draft September 10, 2024 21:40
@scottaddie scottaddie marked this pull request as ready for review September 10, 2024 21:42
@RobertCraigie RobertCraigie changed the title Edit pass on Azure OpenAI section of README docs(azure): remove local from docs link Sep 11, 2024
@RobertCraigie RobertCraigie changed the title docs(azure): remove local from docs link docs(azure): remove locale from docs link Sep 11, 2024
@RobertCraigie RobertCraigie changed the base branch from master to next September 11, 2024 10:11
RobertCraigie
RobertCraigie approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@RobertCraigie RobertCraigie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@RobertCraigie RobertCraigie merged commit f9b7eac into openai:next Sep 11, 2024
3 checks passed
@stainless-app stainless-app bot mentioned this pull request Sep 11, 2024
Merged
@scottaddie scottaddie deleted the scottaddie/azure-ad-rename branch September 11, 2024 13:25
stainless-app bot pushed a commit that referenced this pull request Sep 11, 2024
@scottaddie @stainless-app
docs(azure): remove locale from docs link (#1054)
fc549fc
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertCraigie RobertCraigie RobertCraigie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottaddie @RobertCraigie