Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could we remove tls.client.server_name in favor of server.address #1211

Closed
lmolkova opened this issue Jul 6, 2024 · 2 comments · Fixed by #1216
Closed

Could we remove tls.client.server_name in favor of server.address #1211

lmolkova opened this issue Jul 6, 2024 · 2 comments · Fixed by #1216
Assignees
Labels
area:tls bug Something isn't working

Comments

@lmolkova
Copy link
Contributor

lmolkova commented Jul 6, 2024

tls.client.server_name is defined as

| `tls.client.server_name` | string | Also called an SNI, this tells the server which hostname to which the client is attempting to connect to. | `opentelemetry.io` | ![Experimental](https://img.shields.io/badge/-experimental-blue) |

This should be the same as server.address. See https://community.f5.com/kb/technicalarticles/ssl-profiles-part-7-server-name-indication/279829

So the proposal is to deprecate the tls.client.server_name attribute.

@lmolkova lmolkova added bug Something isn't working area:tls labels Jul 6, 2024
@joaopgrassi
Copy link
Member

CC @svrnm

@svrnm
Copy link
Member

svrnm commented Jul 8, 2024

When I added this originally I took most attributes from Elastic Common Schema, so I had no other reason than that for adding it.

+1 for deprecation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:tls bug Something isn't working
Projects
None yet
4 participants