Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource conventions: Many ambiguities #605

Open
kbrockhoff opened this issue May 14, 2020 · 4 comments
Open

Resource conventions: Many ambiguities #605

kbrockhoff opened this issue May 14, 2020 · 4 comments
Assignees
Labels
area:semantic-conventions Related to semantic conventions release:after-ga Not required before GA release, and not going to work on before GA spec:resource Related to the specification/resource directory
Milestone

Comments

@kbrockhoff
Copy link
Member

In the existing Resource attributes names currently appear to be sufficient to cover most use cases. However, there are many ambiguities around which attributes should be populated for a particular use case and what system property should supply the value.

There are multiple facets to this. For example, some attribute types have a required column while others don't. At least one other open issue highlights a specific item within the overall problem. #559

In order to ensure consistent implementation across all of the officially supported SDKs, I propose adding a matrix with attributes on one axis and deployment environments on the other, specifying whether an attribute should be populated and exactly where the value should be obtained from if it is populated.

@arminru arminru added area:semantic-conventions Related to semantic conventions spec:resource Related to the specification/resource directory labels May 14, 2020
@bogdandrutu bogdandrutu self-assigned this May 15, 2020
@arminru arminru added this to the v0.5 milestone May 26, 2020
@carlosalberto carlosalberto modified the milestones: v0.5, v0.6 Jun 9, 2020
@reyang reyang added the release:required-for-ga Must be resolved before GA release, or nice to have before GA label Jul 6, 2020
@andrewhsu andrewhsu added the priority:p3 Lowest priority level label Jul 24, 2020
@tigrannajaryan
Copy link
Member

I think consistency is at least partially solved by YAML generator. Do we still need this and is it a must-have for GA?

@andrewhsu
Copy link
Member

@kbrockhoff from the issue triage mtg today, trying to bucket issues that can be addressed after GA. if you don't have more info on this by 2020-09-10, this issue will be moved to after-ga.

@kbrockhoff
Copy link
Member Author

I envision this as documentation explaining the specification. This can easily be after-ga

@tigrannajaryan tigrannajaryan added release:after-ga Not required before GA release, and not going to work on before GA and removed release:required-for-ga Must be resolved before GA release, or nice to have before GA labels Sep 9, 2020
@carlosalberto
Copy link
Contributor

@kbrockhoff Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions release:after-ga Not required before GA release, and not going to work on before GA spec:resource Related to the specification/resource directory
Projects
None yet
Development

No branches or pull requests

7 participants