Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics: Specify the default aggregation for Measure instruments #462

Closed
jmacd opened this issue Feb 13, 2020 · 2 comments · Fixed by open-telemetry/oteps#98
Closed

Metrics: Specify the default aggregation for Measure instruments #462

jmacd opened this issue Feb 13, 2020 · 2 comments · Fixed by open-telemetry/oteps#98
Assignees
Labels
spec:metrics Related to the specification/metrics directory
Milestone

Comments

@jmacd
Copy link
Contributor

jmacd commented Feb 13, 2020

The current specification says that Measure instruments default to "MinMaxSumCount" aggregation, which outputs four values. The question is whether it typically makes more sense to reduce this to only the Sum and Count aggregations (i.e., two values).

See this comment: #430 (comment)

The rationale for making Min/Max/Sum and Count aggregations be the default is that these four values are all cheap-to-compute summary statistics. It was mentioned in today's SIG that these are the default behavior for a Prometheus Summary metric instrument, but I could not find evidence for this assertion.

@jmacd jmacd added the spec:metrics Related to the specification/metrics directory label Feb 13, 2020
@jmacd jmacd added this to the v0.4 milestone Feb 13, 2020
@jmacd
Copy link
Contributor Author

jmacd commented Feb 20, 2020

@bogdandrutu I believe your position was that Min and Max are not often used and will cause unnecessary reporting. Is that it?

I like to include Min and Max because it cheaply tells us something about the distribution of values.

@jmacd
Copy link
Contributor Author

jmacd commented Apr 28, 2020

This will close when OTEP 98 is approved and merged into the specification.
Please review: open-telemetry/oteps#98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant