Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common namespace for browser and mobile attributes #3351

Closed
scheler opened this issue Mar 30, 2023 · 3 comments
Closed

Common namespace for browser and mobile attributes #3351

scheler opened this issue Mar 30, 2023 · 3 comments
Assignees
Labels
area:client RUM and other client instrumentation issues area:semantic-conventions Related to semantic conventions spec:resource Related to the specification/resource directory

Comments

@scheler
Copy link
Contributor

scheler commented Mar 30, 2023

What are you trying to achieve?

This is with reference to this comment #3287 (comment) in a PR that is adding a few semantic conventions to browser namespace. There are some attributes that are common to both browser and mobile app instrumentations, and we were wondering what namespace to use if we have to use one common namespace for attributes that are relevant to both these domains (eg., session id, visitor id). Would client be appropriate?

cc: @MSNev @martinkuba @breedx-splk @bryce-b

@scheler scheler added the spec:resource Related to the specification/resource directory label Mar 30, 2023
@reyang
Copy link
Member

reyang commented Apr 1, 2023

I don't see why session or visitor/user id should be client specific (one can imagine that mobile devices, IoT devices or an ATM machine handling similar concept). Maybe just use "user.id" and "user.session"? I suggest that we learn from ECS open-telemetry/oteps#222 and try to align as much as possible.

@arminru arminru added area:semantic-conventions Related to semantic conventions area:client RUM and other client instrumentation issues labels Apr 4, 2023
@scheler
Copy link
Contributor Author

scheler commented Apr 5, 2023

@reyang it doesn't look like user namespace exists currently. There is enduser, however, so did you intend to suggest enduser.id and enduser.session instead?

We discussed the following in the Client Instrumentation SIG today -

  • visitor_id and impression_id fit into user or enduser whichever we want to keep.
  • session_id fits into client namespace, if that is allowed to be introduced.

I looked into ECS's client namespace - it overlaps with net namespace in OTel. If there is a plan to move the networking client aspects to client namespace, then we could use it for having session_id as well.

cc: @jsuereth

@scheler
Copy link
Contributor Author

scheler commented Jun 7, 2024

Closing; the common attributes will be taken up on a case by case basis.

@scheler scheler closed this as completed Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:client RUM and other client instrumentation issues area:semantic-conventions Related to semantic conventions spec:resource Related to the specification/resource directory
Projects
Development

No branches or pull requests

3 participants