Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adopting ECS convention for logging spec's Trace Context in Legacy Formats #3303

Closed
trask opened this issue Mar 8, 2023 · 4 comments · Fixed by #3909
Closed

Consider adopting ECS convention for logging spec's Trace Context in Legacy Formats #3303

trask opened this issue Mar 8, 2023 · 4 comments · Fixed by #3909
Assignees
Labels
spec:logs Related to the specification/logs directory triage:accepted:ready-with-sponsor

Comments

@trask
Copy link
Member

trask commented Mar 8, 2023

Currently, the logging spec's Trace Context in Legacy Formats says:

the following field names should be used in legacy formats:

"trace_id" for TraceId, hex-encoded.
"span_id" for SpanId, hex-encoded.
"trace_flags" for trace flags, formatted according to W3C traceflags format.

I think it's worth considering using instead the ECS field names trace.id, span.id and trace.flags.

Related: open-telemetry/opentelemetry-java-instrumentation#7985

cc @AlexanderWert

@dashpole
Copy link
Contributor

Is this issue still being considered? I see elastic/ecs-logging-java#214 (comment), #3469, and #3518 suggest we are planning to keep the current field names.

I'm interested in seeing https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/compatibility/logging_trace_context.md reach stability, and this appears to be the only related issue.

@jack-berg @tigrannajaryan

@tigrannajaryan
Copy link
Member

I think the conclusion in #3518 was that we keep the names. It has been a while and there is no new evidence that we need to do something else so I suggest that we submit a PR that declares https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/compatibility/logging_trace_context.md "Stable" and closes this issue.
@dashpole do you want to do it?

@dashpole
Copy link
Contributor

PR: #3909

@svrnm
Copy link
Member

svrnm commented May 6, 2024

@open-telemetry/technical-committee please take a look, the PRs related to this have been auto-closed, is this something that is done or that needs additional attention?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment