Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http.route SHOULD include application root #3156

Closed
trask opened this issue Jan 31, 2023 · 0 comments · Fixed by #3164
Closed

http.route SHOULD include application root #3156

trask opened this issue Jan 31, 2023 · 0 comments · Fixed by #3164
Assignees
Labels
semconv:HTTP spec:trace Related to the specification/trace directory

Comments

@trask
Copy link
Member

trask commented Jan 31, 2023

What are you trying to achieve?

Clarity that "application root" SHOULD be included in http.route (in cases where there is an application root).

There is language in the HTTP tracing spec which implies it may or may not be:

Given an inbound request for a route (e.g. "/users/:userID?") the name attribute of the span SHOULD be set to this route.
If the route does not include the application root, it SHOULD be prepended to the span name.

I'd like to remove this sentence:

If the route does not include the application root, it SHOULD be prepended to the span name.

and instead add a note to the http.route definition that "it SHOULD include the application root (if there is one)"

@trask trask added spec:trace Related to the specification/trace directory semconv:HTTP labels Jan 31, 2023
@trask trask assigned trask and unassigned SergeyKanzhelev Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semconv:HTTP spec:trace Related to the specification/trace directory
Projects
Development

Successfully merging a pull request may close this issue.

2 participants