Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: Release 10 gems #1465

Merged
merged 6 commits into from
Jun 13, 2023
Merged

release: Release 10 gems #1465

merged 6 commits into from
Jun 13, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 8, 2023 •
edited by robertlaurin
Loading

This pull request prepares new gem releases for the following gems:

  • opentelemetry-api 1.2.0 (was 1.1.0)
  • opentelemetry-registry 0.3.0 (was 0.2.0)
  • opentelemetry-sdk 1.3.0 (was 1.2.1)
  • opentelemetry-sdk-experimental 0.3.0 (was 0.2.0)
  • opentelemetry-common 0.20.0 (was 0.19.7)
  • opentelemetry-exporter-jaeger 0.23.0 (was 0.22.0)
  • opentelemetry-exporter-zipkin 0.23.0 (was 0.22.0)
  • opentelemetry-propagator-b3 0.21.0 (was 0.20.0)
  • opentelemetry-propagator-jaeger 0.21.0 (was 0.20.0)
  • opentelemetry-test-helpers 0.4.0 (was 0.3.0)

For each gem, this pull request modifies the gem version and provides an initial changelog entry based on conventional commit messages. You can edit these changes before merging, to release a different version or to alter the changelog text.

  • To confirm this release, merge this pull request, ensuring the "release: pending" label is set. The release script will trigger automatically on merge.
  • To abort this release, close this pull request without merging.

The generated changelog entries have been copied below:

opentelemetry-api

v1.2.0 / 2023-06-08

  • BREAKING CHANGE: Remove support for EoL Ruby 2.7

  • ADDED: Remove support for EoL Ruby 2.7

opentelemetry-registry

v0.3.0 / 2023-06-08

  • BREAKING CHANGE: Remove support for EoL Ruby 2.7

  • ADDED: Remove support for EoL Ruby 2.7

opentelemetry-sdk

v1.3.0 / 2023-06-08

  • BREAKING CHANGE: Remove support for EoL Ruby 2.7

  • ADDED: Remove support for EoL Ruby 2.7

  • FIXED: SDK requires opentelemetry-common 0.19.7

opentelemetry-sdk-experimental

v0.3.0 / 2023-06-08

  • BREAKING CHANGE: Remove support for EoL Ruby 2.7

  • ADDED: Remove support for EoL Ruby 2.7

opentelemetry-common

v0.20.0 / 2023-06-08

  • BREAKING CHANGE: Remove support for EoL Ruby 2.7

  • ADDED: Remove support for EoL Ruby 2.7

opentelemetry-exporter-jaeger

v0.23.0 / 2023-06-08

  • BREAKING CHANGE: Remove support for EoL Ruby 2.7

  • ADDED: Remove support for EoL Ruby 2.7

opentelemetry-exporter-zipkin

v0.23.0 / 2023-06-08

  • BREAKING CHANGE: Remove support for EoL Ruby 2.7

  • ADDED: Remove support for EoL Ruby 2.7

opentelemetry-propagator-b3

v0.21.0 / 2023-06-08

  • BREAKING CHANGE: Remove support for EoL Ruby 2.7

  • ADDED: Remove support for EoL Ruby 2.7

opentelemetry-propagator-jaeger

v0.21.0 / 2023-06-08

  • BREAKING CHANGE: Remove support for EoL Ruby 2.7

  • ADDED: Remove support for EoL Ruby 2.7

opentelemetry-test-helpers

v0.4.0 / 2023-06-08

  • BREAKING CHANGE: Remove support for EoL Ruby 2.7

  • ADDED: Remove support for EoL Ruby 2.7

@github-actions github-actions bot added the release: pending Automated release is pending label Jun 8, 2023
robertlaurin
robertlaurin reviewed Jun 8, 2023
View reviewed changes
exporter/jaeger/opentelemetry-exporter-jaeger.gemspec
@@ -27,7 +27,7 @@ Gem::Specification.new do |spec|
spec.required_ruby_version = '>= 3.0'

spec.add_dependency 'opentelemetry-api', '~> 1.1'
spec.add_dependency 'opentelemetry-common', '~> 0.19.6'
spec.add_dependency 'opentelemetry-common', '~> 0.20'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I loosened the constrain here and bumped the minimum required version, not sure if anyone has any concerns on that. That was what we did in the past before contrib, I think it should still be ok now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. I play this game with contrib all the time.

fbogsany
fbogsany reviewed Jun 9, 2023
View reviewed changes
semantic_conventions/lib/opentelemetry/semantic_conventions/version.rb Outdated
@@ -6,6 +6,6 @@

module OpenTelemetry
module SemanticConventions
VERSION = '1.10.0'
VERSION = '2.0.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is problematic. Until now, we have had this version track the corresponding semantic conventions spec version. I think we should try to continue with that, if possible. TBH, part of me doesn't want to bump this at all.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be sufficient to not release it I believe 47cfc77

@robertlaurin robertlaurin changed the title release: Release 11 gems release: Release 10 gems Jun 9, 2023
@robertlaurin robertlaurin merged commit 4fbf7e4 into main Jun 13, 2023
@robertlaurin robertlaurin deleted the release/multi/20230608221703 branch June 13, 2023 13:56
@github-actions github-actions bot added release: error Automated release failed with an error and removed release: pending Automated release is pending labels Jun 13, 2023
@github-actions
Copy link
Contributor Author

Release job completed with errors.

GitHub checks still failing after 1200 secs.
GitHub check "opentelemetry-exporter-otlp / ubuntu-latest" was not successful
No releases were performed.

@github-actions github-actions bot mentioned this pull request Jun 13, 2023
Closed
@github-actions github-actions bot added release: complete Automated release completed successfully and removed release: error Automated release failed with an error labels Jun 13, 2023
@github-actions
Copy link
Contributor Author

All releases completed successfully.

Successfully released opentelemetry-api 1.2.0

Successfully released opentelemetry-registry 0.3.0

Successfully released opentelemetry-sdk 1.3.0

Successfully released opentelemetry-sdk-experimental 0.3.0

Successfully released opentelemetry-common 0.20.0

Successfully released opentelemetry-exporter-jaeger 0.23.0

Successfully released opentelemetry-exporter-otlp 0.25.0

Successfully released opentelemetry-exporter-zipkin 0.23.0

Successfully released opentelemetry-propagator-b3 0.21.0

Successfully released opentelemetry-propagator-jaeger 0.21.0

Successfully released opentelemetry-test-helpers 0.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertlaurin robertlaurin robertlaurin left review comments

@fbogsany fbogsany fbogsany approved these changes

@mwear mwear Awaiting requested review from mwear mwear is a code owner

@dazuma dazuma Awaiting requested review from dazuma dazuma is a code owner

@ericmustin ericmustin Awaiting requested review from ericmustin ericmustin is a code owner

@arielvalentin arielvalentin Awaiting requested review from arielvalentin arielvalentin is a code owner

@ahayworth ahayworth Awaiting requested review from ahayworth ahayworth is a code owner

@plantfansam plantfansam Awaiting requested review from plantfansam plantfansam is a code owner

@robbkidd robbkidd Awaiting requested review from robbkidd robbkidd is a code owner

Assignees
No one assigned
Labels
release: complete Automated release completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arielvalentin @fbogsany @robertlaurin @dazuma