fix: SDK requires opentelemetry-common 0.19.7 #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plantfansam
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth and
robbkidd
as code owners
robertlaurin
approved these changes
Jun 2, 2023
plantfansam
force-pushed
the
plantfansam-patch-1
branch
from
f314cec
to
f93ce92
Compare
🤦 f93ce92 |
|
@robertlaurin does it read the commits or does it read the PR titles? |
I thought it was the commits |
robertlaurin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1412, the SDK picked up a dependency on the
untraced?method inopentelemetry-common, which was added in0.19.7(same PR) (https://github.com/open-telemetry/opentelemetry-ruby/blob/main/common/CHANGELOG.md#v0197--2023-05-30).