Changing supported version of tornado to 6.0 and above #909
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Agent fails to detach context with tornado 5.1.1. The issue comes because
contextvars
does not work perfectly with tornado'sgen.coroutine
as mentioned in this issue.contextvars
has problems with resetting the context withgen.coroutine
. The fix for this is implemented in tornado 6.1In tornado 5.1.1
_execute
is implemented asgen.coroutine
link whereas it is converted to a native coroutine in tornado 6 link.contextvars
works corretcly with native coroutines. So, changing the supported version for the agent to tornado>=6 solves the issue.Type of change
How Has This Been Tested?
Reproduce the issue: Running instrumented tornado 5.1.1 app with agent throws error.
ERROR:opentelemetry.context:Failed to detach context
This error doesn’t come with tornado>=6. Tested by running manually.
Details on the setup to reproduce can be found in the comment thread of the issue #904
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.