Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs API/SDK] Drop include_trace_context parameter from LoggerProvider::GetLogger() #2104

Closed
lalitb opened this issue Apr 19, 2023 · 0 comments · Fixed by #2194
Closed

[Logs API/SDK] Drop include_trace_context parameter from LoggerProvider::GetLogger() #2104

lalitb opened this issue Apr 19, 2023 · 0 comments · Fixed by #2194
Labels
bug Something isn't working

Comments

@lalitb
Copy link
Member

lalitb commented Apr 19, 2023

As per the specs changes - open-telemetry/opentelemetry-specification#3397, the include_trace_context argument should be removed from LoggerProvider::GetLogger() method. The logger should use trace flags if explicitly set through LogRecord::SetTraceFlags(), else it should implicitly extract them from current Context inside Logger::EmitLogRecord method.

@lalitb lalitb added the bug Something isn't working label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant