Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prometheus Exporter] Ensure Prometheus Exporter respond to OTLP data format from Prometheus Receiver #6805

Closed
hyunuk opened this issue Dec 14, 2021 · 1 comment
Assignees
Labels
comp:prometheus Prometheus related issues

Comments

@hyunuk
Copy link
Contributor

hyunuk commented Dec 14, 2021

This issue is identical with #6620 but for Prometheus Exporter.

Is your feature request related to a problem? Please describe.
In regards to the issue #6376, the metric builder does not assign staleNaN values to the histogram and summary values for failed scrapes from Prometheus scrape loop. Therefore, the proposed possible solution is to use the OTLP format in the OTLP Prometheus Receiver with datapoint flags as a staleness marker for metrics with no-value present to address this issue.

Accordingly, if the metrics contain the OTLP flag that indicates MetricDataPointFlagNoRecordedValue, the Prometheus Exporter should be able to handle and respond to the OTLP flag for staleness. This allows end-to-end compatibility in the collector pipeline with the use of OTLP native staleness marker flag, from the Prometheus Receiver to the Prometheus Exporter.

Describe the solution you'd like
A possible solution is to check every data point for all metrics data types for the OTLP MetricDataPointFlagNoRecordedValue flag, and drop the metric if the flag is enabled. This ensures the Prometheus Exporter to handle and respond to the OTLP flag for staleness in the collector pipeline.

Additional context
Related issue: #6376, #6620

cc @alolita

@alolita
Copy link
Member

alolita commented Jan 5, 2022

Resolved. Closing issue.

@alolita alolita closed this as completed Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:prometheus Prometheus related issues
Projects
None yet
Development

No branches or pull requests

2 participants