Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/aerospike] Determine future of component #33398

Closed
4 tasks
TylerHelmuth opened this issue Jun 5, 2024 · 6 comments · Fixed by #34244
Closed
4 tasks

[receiver/aerospike] Determine future of component #33398

TylerHelmuth opened this issue Jun 5, 2024 · 6 comments · Fixed by #34244
Labels
discussion needed Community discussion needed help wanted Extra attention is needed receiver/aerospike

Comments

@TylerHelmuth
Copy link
Member

TylerHelmuth commented Jun 5, 2024

Component(s)

receiver/aerospike

Details

We have a problem right now where we can't upgrade github.com/aerospike/aerospike-client-go, the core dependency of the Aerospike Receiver, due to a proto name conflict. We've made several attempts since August 2023, but haven't had any success. We're getting into worrisome territory, where our version is falling behind, and there have been security releases we can't take.

I'm opening this issue not because the code owners have not tried to fix the issue, but because I am worried about maintaining a component with a dependency we can't upgrade. @antonblock @djaglowski what do you want to do here?

Generic Unmaintained Issue Template:

  • Wait 6 weeks for the code owner to provide feedback, either here or in the linked issue
  • Attempt to recruit new code owners, potentially from the community (cc @antonblock @djaglowski)
  • On 2024-07-17, 6 weeks from now, the component will be labeled as unmaintained if the original code owner is still unresponsive and no other code owner for the component has been found
  • On 2024-12-05, 6 months from now, the component will be removed

https://github.com/open-telemetry/opentelemetry-collector#unmaintained

Pull requests / Issues

@TylerHelmuth TylerHelmuth added help wanted Extra attention is needed unmaintained Identifies issues/prs for unmaintained components labels Jun 5, 2024
Copy link
Contributor

github-actions bot commented Jun 5, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@djaglowski
Copy link
Member

@khaf, you previously commented here about the potential root cause of the upgrade problem. Do you still think this is the problem and if so, do you have any hope it will be resolved upstream in the client library?

@crobert-1
Copy link
Member

Removing unmaintained as a code owner has responded. I understand more discussion is necessary regarding the path forward here, so I'm adding discussion needed. Feel free to correct me if I've missed something.

@crobert-1 crobert-1 added discussion needed Community discussion needed and removed unmaintained Identifies issues/prs for unmaintained components labels Jun 6, 2024
@khaf
Copy link

khaf commented Jun 6, 2024

@djaglowski I thought adding a package name in the manifest would help, but it didn't. What I'm going to do personally is that I'll try to reproduce the issue in open-telemetry and come up with a fix in the Go client. What I need though is a simple shell incantation that would allow me to reproduce the issue. Appreciate your help.

@djaglowski
Copy link
Member

djaglowski commented Jun 6, 2024

@khaf, I noted on the upstream issue here, but I was able to write a unit test which demonstrates the problem. I hope it's helpful. Really appreciate you looking into this.

@djaglowski
Copy link
Member

The latest version of the dependency has resolved the underlying issue. I've opened #34244 to perform the upgrade on our end. Thanks again @khaf!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion needed Community discussion needed help wanted Extra attention is needed receiver/aerospike
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants