Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove anuraaga from approvers #3337

Closed
anuraaga opened this issue May 6, 2021 · 2 comments
Closed

Remove anuraaga from approvers #3337

anuraaga opened this issue May 6, 2021 · 2 comments
Labels
comp:aws AWS components

Comments

@anuraaga
Copy link
Contributor

anuraaga commented May 6, 2021

Currently, there are four ways I get added to PRs

  • Automatically assigned
  • Implicit review request via the approvers team
  • Explicit review request (didn't know this was happening until just noticed it now)
  • at-mention

In particular, the implicit review request via the approvers team makes it very difficult which PRs I'm supposed to focus on, especially when there are also explicit review requests coming in as they're labeled the exact same in GitHub notifications.

I think it will actually improve my ability to help by being removed from the approvers team. Instead, I'd like to be in the CODEOWNERS for aws folders, and I'm always happy to be explicitly added to a PR in any of the ways. Without the implicit review requests, I'll be able to respond much more precisely.

Cheers!

@anuraaga
Copy link
Contributor Author

anuraaga commented May 6, 2021

Note discussed alternatives in #2736 but doesn't seem to be. I think it's ok, approvers doesn't mean merge rights anyways so doesn't seem to be a huge difference in me being there.

@anuraaga
Copy link
Contributor Author

anuraaga commented Jun 1, 2021

#1339 hasn't had any action. Can @bogdandrutu or @tigrannajaryan go ahead and make the change to the GitHub team? I'm still in CODEOWNERS for folders that I need to focus on so hope to still help - conversely, I can't actually focus on those given the current settings.

@anuraaga anuraaga removed the good first issue Good for newcomers label Jun 1, 2021
alexperez52 referenced this issue in open-o11y/opentelemetry-collector-contrib Aug 18, 2021
@alolita alolita added the comp:aws AWS components label Sep 2, 2021
@alolita alolita closed this as completed Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:aws AWS components
Projects
None yet
Development

No branches or pull requests

2 participants