Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/azuremonitor] Why span events are pushed as traces and not as custom events? #26470

Closed
ghost opened this issue Sep 5, 2023 · 4 comments

Comments

@ghost
Copy link

ghost commented Sep 5, 2023

Component(s)

exporter/azuremonitor

Describe the issue you're reporting

Azure Monitor supports custom events: https://learn.microsoft.com/en-us/azure/azure-monitor/app/api-custom-events-metrics#trackevent

I wonder why span events are pushed as traces and not as custom events by the Azure Monitor exporter?

messageData := spanEventToMessageData(spanEvent)

cc @pcwiese @cijothomas @TylerHelmuth

@ghost ghost added the needs triage New item requiring triage label Sep 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@cijothomas
Copy link
Member

CustomEvents in application insights is not same as SpanEvents, though the name is similar. SpanEvent is more like "logs", except they are always attached to a Span, and this is better mapped as TraceTelemetry, as that is where general "logs" are stored in ApplicationInsights.

This collector component is not an official Microsoft/Azure component, but if you look at the official ones (the java/.net/node/python exporters in Azure repo), they are mapping SpanEvents to TraceTelemetry.

@cijothomas
Copy link
Member

Thanks for the explanation. There's no way to produce CustomEvents through OTLP in this case, right?

correct.
(In the future it might be possible with https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/event-api.md, but given that spec is experimental, its hard to tell now).

@crobert-1
Copy link
Member

@cakescience Is there anymore information needed here? Just want to make sure it's safe to close this issue.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants