fix: now if loading user profile fails an error is thrown instead of 404ing #4043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nickytonline
changed the title
nickytonline
force-pushed
the
nickytonline/user-profile-bug
branch
from
fddf6e4
to
b637a29
Compare
nickytonline
commented
Aug 27, 2024
brandonroberts
approved these changes
Aug 27, 2024
jpmcb
approved these changes
Aug 27, 2024
open-sauced bot
pushed a commit
that referenced
this pull request
Aug 27, 2024
## [2.61.0-beta.6](v2.61.0-beta.5...v2.61.0-beta.6) (2024-08-27) ### 🍕 Features * add contributor confidence to repository table ([#4038](#4038)) ([6f510cb](6f510cb)) * now html2canvas-pro is dynamically imported only when needed and then cached ([#4044](#4044)) ([23e4d76](23e4d76)) ### 🐛 Bug Fixes * now if loading user profile fails an error is thrown instead of 404ing ([#4043](#4043)) ([3527795](3527795)) * update validation for GitHub username ([#4046](#4046)) ([8a77fac](8a77fac))
open-sauced bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
## [2.61.0](v2.60.0...v2.61.0) (2024-08-29) ### 🍕 Features * add contributor confidence to repository table ([#4038](#4038)) ([6f510cb](6f510cb)) * Add contributor's insight on the workspace. ([#4060](#4060)) ([7c4b60b](7c4b60b)) * copy repo page `ForksChart` as image ([#4036](#4036)) ([d30beff](d30beff)) * copy repo page `StarsChart` as image ([#4035](#4035)) ([933bb2c](933bb2c)) * copy repo page Contributors chart as image ([#4025](#4025)) ([581497e](581497e)) * copy repo page Issues chart as image ([#4026](#4026)) ([f9fad65](f9fad65)) * copy repo page PR chart as image ([#4027](#4027)) ([3541a37](3541a37)) * display lottery factor on Repository Table ([#4059](#4059)) ([48343e0](48343e0)) * implemented the split button component ([#4040](#4040)) ([a539f78](a539f78)) * now html2canvas-pro is dynamically imported only when needed and then cached ([#4044](#4044)) ([23e4d76](23e4d76)) * OSCR learn more link opens in a new tab now ([#4056](#4056)) ([b8b1a00](b8b1a00)) * refresh explore page to only loading repositories ([#4019](#4019)) ([88f5937](88f5937)) * Use powerful self hosted runner for playwright tests ([#4069](#4069)) ([28f493e](28f493e)) * Use self hosted GitHub actions runners ([#4064](#4064)) ([d62066d](d62066d)) ### 🐛 Bug Fixes * `RossChart` order changing on filter ([#4018](#4018)) ([64a04f5](64a04f5)) * align OSCR pill with the username ([#4048](#4048)) ([0cc087d](0cc087d)) * correct width issue caused by tooltip addition in SingleSelect ([#4058](#4058)) ([b6e1173](b6e1173)) * fixed typo for recommendations ([#4017](#4017)) ([2e4cbdb](2e4cbdb)) * now if loading user profile fails an error is thrown instead of 404ing ([#4043](#4043)) ([3527795](3527795)) * now search dialog is always on top of other elements ([#4047](#4047)) ([3b4101a](3b4101a)) * remove deprecated "add coupon" section from user settings page ([#4039](#4039)) ([0b61b77](0b61b77)) * remove set width for repo pages charts ([#4068](#4068)) ([2dc9062](2dc9062)) * **ossfchart.tsx:** remove z-index and move "I want this now!" button JSX below ResponsiveContainer ([#4066](#4066)) ([8a9066a](8a9066a)) * repository page width overflow ([#4051](#4051)) ([b827d26](b827d26)) * Revert "fix: now search dialog is always on top of other elements ([#4047](#4047))" ([#4054](#4054)) ([cd03a01](cd03a01)) * update validation for GitHub username ([#4046](#4046)) ([8a77fac](8a77fac)) * Use correct github action yamls ([#4071](#4071)) ([9da2739](9da2739))
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now if loading user data fails on a user profile page, an error is thrown instead of 404ing as it's misleading if an existing user is said to not be found.
Related Tickets & Documents
Fixes #4042
Mobile & Desktop Screenshots/Recordings
Steps to QA
Kind of hard to test this atm. The API can 404 if a user isn't found, but then it goes to the stub a user and if that fails it gives a 400.
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?