Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning with torch.meshgrid #577

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pallgeuer
Copy link

Motivation

torch.meshgrid() has started raising a warning when not called with an explicit indexing parameter:
https://pytorch.org/docs/stable/generated/torch.meshgrid.html

Modification

Provide indexing='ij' to all calls to torch.meshgrid that don't already specify indexing.

@pallgeuer
Copy link
Author

Refer to open-mmlab/mmdetection#8090 (comment) for discussion on PyTorch version support of torch.meshgrid.

@GT9505
Copy link
Collaborator

GT9505 commented May 31, 2022

Very appreciate your contribution.

After discussing a general solution in your posted pr of mmdet, we can use the same behavior to fix the bug.

@pallgeuer
Copy link
Author

I have updated the PR based on the same solution used for mmpose and mmdet.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants