Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

call after_val_epoch hooks only once to save best ckpt correctly #421

Merged
merged 1 commit into from
Feb 13, 2023
Merged

call after_val_epoch hooks only once to save best ckpt correctly #421

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 4 additions & 17 deletions mmrazor/engine/runner/distill_val_loop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,30 +52,17 @@ def run(self):
self.run_iter(idx, data_batch)
# compute student metrics
metrics = self.evaluator.evaluate(len(self.dataloader.dataset))
student_metrics = dict()
for key, value in metrics.items():
student_key = 'student.' + key
teacher_key = 'teacher.' + key

student_metrics[student_key] = value
self.runner.message_hub.log_scalars.pop(f'val/{teacher_key}', None)

self.runner.call_hook('after_val_epoch', metrics=student_metrics)

self.runner.call_hook('before_val_epoch')
for idx, data_batch in enumerate(self.dataloader):
self.run_iter_teacher(idx, data_batch)
# compute teacher metrics
metrics = self.evaluator.evaluate(len(self.dataloader.dataset))
teacher_metrics = dict()
for key, value in metrics.items():
student_key = 'student.' + key
teacher_metrics = self.evaluator.evaluate(len(self.dataloader.dataset))
for key, value in teacher_metrics.items():
teacher_key = 'teacher.' + key
metrics[teacher_key] = value

teacher_metrics[teacher_key] = value
self.runner.message_hub.log_scalars.pop(f'val/{student_key}', None)

self.runner.call_hook('after_val_epoch', metrics=teacher_metrics)
self.runner.call_hook('after_val_epoch', metrics=metrics)
self.runner.call_hook('after_val')

@torch.no_grad()
Expand Down