Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]Dump config before training #282

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

LXXXXR
Copy link
Contributor

@LXXXXR LXXXXR commented Jun 1, 2021

Hi,

This pull request adds dumping config before training to align with other repos and makes it easier to reproduce experiments. Thx.

@LXXXXR LXXXXR requested review from ycxioooong and removed request for ycxioooong June 1, 2021 02:47
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #282 (ee770fb) into master (5ff158c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #282   +/-   ##
=======================================
  Coverage   73.30%   73.30%           
=======================================
  Files          88       88           
  Lines        4611     4611           
  Branches      805      805           
=======================================
  Hits         3380     3380           
  Misses       1129     1129           
  Partials      102      102           
Flag Coverage Δ
unittests 73.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ff158c...ee770fb. Read the comment docs.

@LXXXXR LXXXXR requested a review from ycxioooong June 1, 2021 03:00
Copy link
Contributor

@ycxioooong ycxioooong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ycxioooong ycxioooong merged commit 5066e32 into open-mmlab:master Jun 4, 2021
mzr1996 pushed a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants