Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add swin-transformer model. #271

Merged
merged 30 commits into from
Jul 1, 2021
Merged

[Feature] Add swin-transformer model. #271

merged 30 commits into from
Jul 1, 2021

Conversation

mzr1996
Copy link
Member

@mzr1996 mzr1996 commented May 26, 2021

Reproduce swin-transformer model and training recipes.

@mzr1996 mzr1996 added the WIP label May 27, 2021
jshilong
jshilong reviewed May 29, 2021
View reviewed changes
mmcls/models/backbones/swin_transformer.py Outdated Show resolved Hide resolved
mmcls/models/backbones/swin_transformer.py Show resolved Hide resolved
mmcls/models/backbones/swin_transformer.py Outdated Show resolved Hide resolved
mmcls/models/backbones/swin_transformer.py Outdated Show resolved Hide resolved
mmcls/models/backbones/swin_transformer.py Outdated Show resolved Hide resolved
mmcls/models/backbones/swin_transformer.py Outdated Show resolved Hide resolved
mmcls/models/backbones/swin_transformer.py Outdated Show resolved Hide resolved
mmcls/models/backbones/swin_transformer.py Outdated Show resolved Hide resolved
@mzr1996 mzr1996 force-pushed the swin branch 2 times, most recently from e832b7d to e1dd054 Compare June 2, 2021 11:15
@mzr1996 mzr1996 requested a review from ycxioooong June 15, 2021 06:33
@codecov
Copy link

codecov bot commented Jun 22, 2021 •
edited
Loading

Codecov Report

Merging #271 (9bf61bd) into master (4ebee15) will increase coverage by 1.21%.
The diff coverage is 94.16%.

❗ Current head 9bf61bd differs from pull request most recent head 74a7566. Consider uploading reports for the commit 74a7566 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
+ Coverage   73.63%   74.84%   +1.21%     
==========================================
  Files          94       96       +2     
  Lines        4820     5093     +273     
  Branches      816      847      +31     
==========================================
+ Hits         3549     3812     +263     
- Misses       1166     1171       +5     
- Partials      105      110       +5
Flag Coverage Δ
unittests 74.84% <94.16%> (+1.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/models/backbones/swin_transformer.py 90.90% <90.90%> (ø)
mmcls/models/utils/embed.py 78.64% <93.75%> (+12.44%) ⬆️
mmcls/models/utils/attention.py 96.89% <96.89%> (ø)
mmcls/models/backbones/__init__.py 100.00% <100.00%> (ø)
mmcls/models/utils/__init__.py 100.00% <100.00%> (ø)
mmcls/models/utils/helpers.py 100.00% <0.00%> (+15.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ebee15...74a7566. Read the comment docs.

@ycxioooong
Copy link
Contributor

Please resolve the conflicts, thanks.

@mzr1996 mzr1996 changed the title [WIP] Add swin-transformer model. [Feature] Add swin-transformer model. Jun 29, 2021
@mzr1996 mzr1996 removed the WIP label Jun 29, 2021
ycxioooong
ycxioooong approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@ycxioooong ycxioooong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mzr1996
Use nn.Unfold to merge patch
9f5522f
@mzr1996
Change all ConfigDict to dict
e07e301
@mzr1996
Add init_cfg for all subclasses of BaseModule.
a173330
@mzr1996
Use mmcv version init function
80650ad
@mzr1996
Add Swin README
38ccea7
@mzr1996
Use safer cfg copy method
e7e0c6b
@mzr1996
Improve docstring and variable name.
7d691ef
@mzr1996
Fix some difference in randaug
bbbce58 
Fix BGR bug, align scheduler config.

Fix label smoothing parameter difference.
@mzr1996
Fix missing droppath in attn
03effc3
@mzr1996
Fix bug of relative posititon table if window width is not equal to
07afbed 
height.
@mzr1996
Make PatchMerging more general, support kernel, stride, padding and
611915a 
dilation.
@mzr1996
Rename residual to identity in attention and FFN.
a829a70
@mzr1996
Add auto_pad option to auto pad feature map
fcdfde1
@mzr1996
Improve docstring.
cf01372
@mzr1996
Fix bug in ShiftWMSA padding.
5166dcd
@mzr1996
Remove unused key and value in ShiftWMSA
09fabcf
@mzr1996
Move PatchMerging into utils and use common PatchEmbed.
d0f16ff
@mzr1996
Use latest LinearClsHead, train augments and label smooth settings.
32443c1 
And remove original `SwinLinearClsHead`.
@mzr1996
Mark some configs as "Evalution Only".
d7548a0
@mzr1996
Remove useless comment in config
f3da658
@mzr1996
1. Move ShiftWindowMSA and WindowMSA to utils/attention.py
079985b 
2. Add docstrings of each module.
3. Fix some variables' names.
4. Other small improvement.
@mzr1996
Add unit tests of swin-transformer and patchmerging.
64f0f49
@mzr1996
Fix some bugs in unit tests.
8c2b1e2
@mzr1996
Fix bug of rel_position_index if window is not square.
9eff74a
@mzr1996
Make WindowMSA implicit, and add unit tests.
c8d24a9
@mzr1996
Add metafile.yml, update readme and model_zoo.
74a7566
@ycxioooong ycxioooong merged commit 076ee10 into open-mmlab:master Jul 1, 2021
mzr1996 added a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
@mzr1996
[Feature] Add swin-transformer model. (open-mmlab#271)
5f521f6 
* Add swin transformer archs S, B and L.

* Add SwinTransformer configs

* Add train config files of swin.

* Align init method with original code

* Use nn.Unfold to merge patch

* Change all ConfigDict to dict

* Add init_cfg for all subclasses of BaseModule.

* Use mmcv version init function

* Add Swin README

* Use safer cfg copy method

* Improve docstring and variable name.

* Fix some difference in randaug

Fix BGR bug, align scheduler config.

Fix label smoothing parameter difference.

* Fix missing droppath in attn

* Fix bug of relative posititon table if window width is not equal to
height.

* Make `PatchMerging` more general, support kernel, stride, padding and
dilation.

* Rename `residual` to `identity` in attention and FFN.

* Add `auto_pad` option to auto pad feature map

* Improve docstring.

* Fix bug in ShiftWMSA padding.

* Remove unused `key` and `value` in ShiftWMSA

* Move `PatchMerging` into utils and use common `PatchEmbed`.

* Use latest `LinearClsHead`, train augments and label smooth settings.
And remove original `SwinLinearClsHead`.

* Mark some configs as "Evalution Only".

* Remove useless comment in config

* 1. Move ShiftWindowMSA and WindowMSA to `utils/attention.py`
2. Add docstrings of each module.
3. Fix some variables' names.
4. Other small improvement.

* Add unit tests of swin-transformer and patchmerging.

* Fix some bugs in unit tests.

* Fix bug of rel_position_index if window is not square.

* Make WindowMSA implicit, and add unit tests.

* Add metafile.yml, update readme and model_zoo.
@mzr1996 mzr1996 deleted the swin branch December 7, 2022 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Junjun2016 Junjun2016 Junjun2016 left review comments

@xvjiarui xvjiarui xvjiarui left review comments

@ZwwWayne ZwwWayne ZwwWayne left review comments

@jshilong jshilong jshilong left review comments

@ycxioooong ycxioooong ycxioooong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mzr1996 @ycxioooong @Junjun2016 @xvjiarui @ZwwWayne @jshilong