Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix multi-node test tmp dir #251

Merged
merged 2 commits into from
May 16, 2021

Conversation

LXXXXR
Copy link
Contributor

@LXXXXR LXXXXR commented May 12, 2021

Hi,
/tmp dir is usually not shared therefore using a dir under current dir and clean it up afterwards is better.

Pls kindly take a look. Thank you.

Ref: open-mmlab/mmdetection#4017

@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #251 (d298ee6) into master (8c90a87) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #251      +/-   ##
==========================================
+ Coverage   72.83%   72.86%   +0.02%     
==========================================
  Files          88       88              
  Lines        4455     4452       -3     
  Branches      782      780       -2     
==========================================
- Hits         3245     3244       -1     
+ Misses       1109     1108       -1     
+ Partials      101      100       -1     
Flag Coverage Δ
unittests 72.86% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/apis/test.py 23.72% <0.00%> (-0.21%) ⬇️
mmcls/models/builder.py 94.44% <0.00%> (+12.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c90a87...d298ee6. Read the comment docs.

@LXXXXR LXXXXR requested a review from ycxioooong May 13, 2021 02:21
@ycxioooong ycxioooong merged commit dc296f6 into open-mmlab:master May 16, 2021
@LXXXXR LXXXXR deleted the fix_multinode_test branch May 27, 2021 12:46
mzr1996 pushed a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
* fix multi-node test tmp dir

* fix mmcv version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants