-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]fix init of convfc head #6279
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6279 +/- ##
==========================================
- Coverage 68.27% 61.86% -6.41%
==========================================
Files 304 315 +11
Lines 23842 25163 +1321
Branches 3939 4185 +246
==========================================
- Hits 16278 15567 -711
- Misses 6721 8782 +2061
+ Partials 843 814 -29
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I only see comments added, does this PR fix anything? |
I remove |
Motivation
mmdetection/mmdet/models/roi_heads/bbox_heads/convfc_bbox_head.py
Line 103 in c88509c
This line will override initializers for fc_cls and fc_reg because they are also
nn.Linear
.which is not consistent with the old way to initialize
fc_cls
andfc_reg
before #4750.Closes #6238
BC breaking
None