Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]fix init of convfc head #6279

Merged
merged 1 commit into from
Oct 20, 2021
Merged

[BUG]fix init of convfc head #6279

merged 1 commit into from
Oct 20, 2021

Conversation

jshilong
Copy link
Collaborator

@jshilong jshilong commented Oct 14, 2021

Motivation

This line will override initializers for fc_cls and fc_reg because they are also nn.Linear.
which is not consistent with the old way to initialize fc_cls and fc_reg before #4750.

Closes #6238

BC breaking

None

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #6279 (a9d5b62) into master (0fcea45) will decrease coverage by 6.40%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6279      +/-   ##
==========================================
- Coverage   68.27%   61.86%   -6.41%     
==========================================
  Files         304      315      +11     
  Lines       23842    25163    +1321     
  Branches     3939     4185     +246     
==========================================
- Hits        16278    15567     -711     
- Misses       6721     8782    +2061     
+ Partials      843      814      -29     
Flag Coverage Δ
unittests 61.84% <0.00%> (-6.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/core/export/model_wrappers.py 0.00% <0.00%> (ø)
...et/models/roi_heads/bbox_heads/convfc_bbox_head.py 55.88% <ø> (-10.79%) ⬇️
mmdet/models/roi_heads/mask_heads/grid_head.py 7.69% <0.00%> (-87.70%) ⬇️
mmdet/models/roi_heads/mask_scoring_roi_head.py 16.98% <0.00%> (-75.48%) ⬇️
mmdet/models/dense_heads/nasfcos_head.py 28.12% <0.00%> (-68.75%) ⬇️
mmdet/models/seg_heads/panoptic_fpn_head.py 27.65% <0.00%> (-65.82%) ⬇️
mmdet/models/roi_heads/grid_roi_head.py 13.04% <0.00%> (-57.61%) ⬇️
mmdet/models/necks/nas_fpn.py 14.28% <0.00%> (-55.56%) ⬇️
...t/models/detectors/panoptic_two_stage_segmentor.py 16.66% <0.00%> (-52.09%) ⬇️
mmdet/models/utils/normed_predictor.py 33.33% <0.00%> (-50.01%) ⬇️
... and 135 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e876171...a9d5b62. Read the comment docs.

@jshilong jshilong added the bug Something isn't working label Oct 15, 2021
@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Oct 18, 2021

I only see comments added, does this PR fix anything?

@jshilong
Copy link
Collaborator Author

jshilong commented Oct 19, 2021

I only see comments added, does this PR fix anything?

I remove layer='Linear', from init_cfg which would overwide all linear layers when doing the initialization

@ZwwWayne ZwwWayne merged commit 622f0c4 into open-mmlab:master Oct 20, 2021
ZwwWayne pushed a commit to ZwwWayne/mmdetection that referenced this pull request Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]bug in ConvFCBBoxHead's init cfg.
3 participants