-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support QueryInst #6050
Conversation
Hi @vealocia , |
Hi @ZwwWayne . No problem, I will finish it as soon as possible. |
Hi @ZwwWayne , I implement unit tests for |
Suggest merging master to use the CI/CD. |
The latest master branch has been merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall design LGTM, I believe it can be merged after all left conversations are resolved.
@ZwwWayne
@jshilong Your concerns are carefully resolved now! |
@ZwwWayne Maybe we can merge this feature to this or the next version. |
@vealocia Could you benchmark this version and provide corresponding checkpoints and log files via google driver? Many thanks again for your excellent works. @BIGWangYuDong Could you help to process and rename checkpoints from @vealocia and update the URL to the readme? |
I will push my prepared README.md and leave the download link to a placeholder. Thanks for your collaboration too and glad to work with you ;) |
QueryInst pretrained checkpoints can be downloaded here ⬆️ |
I just push the README.md and meta.yaml with leave all link of checkpoints to placeholder. |
|
* impl queryinst * bug free queryinst with crop and negative samples * use detr hyperparameters * pre-commit hooks * modified dynamic_mask_head docstrings * remove unused dropout in dynamic_mask_head * add docstring for dice_loss * add dice_loss unit test * impl unit test for dynamic_mask_head * update queryinst docstring and implementation * stability update for dice_loss and dynamic_mask_head * update for clarify * bug free in case of num_proposals equal to zero * detail docstrings * fixed CI issues * issues resolved * add queryinst docs
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Involve the newly proposed instance segmentation method
QueryInst
intommdetection
Modification
Please briefly describe what modification is made in this PR.
BC-breaking
attn_feats
is added to the returns ofmmdet/models/roi_heads/bbox_heads/dii_head.py
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist