Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

With default setting in mmdet, priority of EvalHook is higher than CheckpointHook #5343

Closed
zhiqi-li opened this issue Jun 13, 2021 · 1 comment
Closed

With default setting in mmdet, priority of EvalHook is higher than CheckpointHook #5343

zhiqi-li opened this issue Jun 13, 2021 · 1 comment
Assignees
@ZwwWayne
Labels
bug Something isn't working

Comments

@zhiqi-li
Copy link

zhiqi-li commented Jun 13, 2021 •
edited
Loading

The EvalHook is registered in apis/train.py by runner.register_hook(eval_hook(val_dataloader, **eval_cfg))

Then mmcv will give EvalHook a default "NORMAL" priority, (NORMAL=50), But the CheckpointHook's default priority is 70.

This means the runner will eval firstly and then save the checkpoint. If there is a bug in the eval-code, and the program crashes, this checkpoint will not be saved. This will cause waste, especially for the time-consuming epoch.
@hhaAndroid hhaAndroid added the bug Something isn't working label Jun 15, 2021
@hhaAndroid hhaAndroid mentioned this issue Jun 15, 2021
Closed
@innerlee innerlee mentioned this issue Jun 17, 2021
Closed
@hhaAndroid
Copy link
Collaborator

Has been fixed by open-mmlab/mmcv#1120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZwwWayne ZwwWayne

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hhaAndroid @zhiqi-li @ZwwWayne