Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arcface head #926

Merged
merged 7 commits into from
Nov 2, 2022
Merged

Add arcface head #926

merged 7 commits into from
Nov 2, 2022

Conversation

zzc98
Copy link
Contributor

@zzc98 zzc98 commented Jul 24, 2022

Motivation

Support ArcFace loss.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@Ezra-Yu Ezra-Yu self-requested a review July 25, 2022 02:01
@Ezra-Yu Ezra-Yu added the 1.0rc Functionalities for MMClassification 1.0rc label Jul 25, 2022
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Base: 0.02% // Head: 91.55% // Increases project coverage by +91.53% 🎉

Coverage data is based on head (bc75e88) compared to base (b8b31e9).
Patch coverage: 59.86% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##           dev-1.x     #926       +/-   ##
============================================
+ Coverage     0.02%   91.55%   +91.53%     
============================================
  Files          121      129        +8     
  Lines         8217     9664     +1447     
  Branches      1368     1517      +149     
============================================
+ Hits             2     8848     +8846     
+ Misses        8215      626     -7589     
- Partials         0      190      +190     
Flag Coverage Δ
unittests 91.55% <59.86%> (+91.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/apis/inference.py 0.00% <0.00%> (ø)
mmcls/datasets/multi_label.py 100.00% <ø> (+100.00%) ⬆️
mmcls/models/backbones/edgenext.py 95.20% <ø> (ø)
mmcls/models/backbones/efficientformer.py 95.08% <ø> (ø)
mmcls/models/backbones/mobileone.py 94.47% <ø> (ø)
mmcls/models/backbones/mvit.py 92.46% <ø> (ø)
mmcls/models/backbones/repvgg.py 96.84% <ø> (+96.84%) ⬆️
mmcls/models/backbones/res2net.py 95.50% <ø> (+95.50%) ⬆️
mmcls/models/backbones/resnet.py 100.00% <ø> (+100.00%) ⬆️
mmcls/models/backbones/shufflenet_v1.py 97.91% <ø> (+97.91%) ⬆️
... and 141 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@okotaku okotaku mentioned this pull request Jul 27, 2022
6 tasks
@okotaku
Copy link
Collaborator

okotaku commented Jul 27, 2022

@zzc98 @Ezra-Yu

Thank you for creating useful components!
I have other arcface implementation and I prefer it.
Please check it too.

#933

@Ezra-Yu Ezra-Yu requested a review from okotaku July 29, 2022 11:04
@zzc98 zzc98 changed the title Add arcface loss Add arcface head Aug 25, 2022
mmcls/models/heads/arcface_head.py Outdated Show resolved Hide resolved
mmcls/models/heads/arcface_head.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@okotaku okotaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mzr1996 mzr1996 merged commit 9506241 into open-mmlab:dev-1.x Nov 2, 2022
mzr1996 pushed a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
* feat: add arcface head

* feat: add arcface head

* update arcface

* refactor archface head

* update archface head

* update archface head

* use torch.cat instead of torch.hstack to fix ci

Co-authored-by: Ezra-Yu <18586273+Ezra-Yu@users.noreply.github.com>
@zzc98 zzc98 deleted the add-arcface branch May 5, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0rc Functionalities for MMClassification 1.0rc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants