Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] further detail for the doc for datasets/dataset_wrappers/ClassBalancedDataset #901

Merged
merged 2 commits into from
Nov 2, 2022

Conversation

xiaoyuan0203
Copy link

@xiaoyuan0203 xiaoyuan0203 commented Jul 7, 2022

Motivation

Further detail for the doc for datasets/dataset_wrappers/ClassBalancedDataset. The original doc seems
confusing in some ways.

Modification

I just modify the docstring for the datasets/dataset_wrappers/ClassBalancedDataset.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Jul 7, 2022

CLA assistant check
All committers have signed the CLA.

@xiaoyuan0203 xiaoyuan0203 changed the title futher detail for the doc for datasets/dataset_wrappers/ClassBalancedDataset further detail for the doc for datasets/dataset_wrappers/ClassBalancedDataset Jul 7, 2022
Copy link
Author

@xiaoyuan0203 xiaoyuan0203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix

@xiaoyuan0203 xiaoyuan0203 marked this pull request as ready for review July 7, 2022 13:52
@xiaoyuan0203 xiaoyuan0203 changed the title further detail for the doc for datasets/dataset_wrappers/ClassBalancedDataset [doc] further detail for the doc for datasets/dataset_wrappers/ClassBalancedDataset Jul 7, 2022
Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mzr1996 mzr1996 merged commit aacaa73 into open-mmlab:master Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants