Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix retrieval multi gpu bug #1319

Merged
merged 3 commits into from
Feb 9, 2023

Conversation

Ezra-Yu
Copy link
Collaborator

@Ezra-Yu Ezra-Yu commented Jan 17, 2023

Motivation

Fix retriever multi-GPUs bug refer to #1310

Modification

  1. handle with DDP-wrapper model
  2. remove the return statement in progress.track_on_main_process, (since there is yield in the function definition).

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Base: 0.02% // Head: 86.85% // Increases project coverage by +86.83% 🎉

Coverage data is based on head (9ea4867) compared to base (b8b31e9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##           dev-1.x    #1319       +/-   ##
============================================
+ Coverage     0.02%   86.85%   +86.83%     
============================================
  Files          121      166       +45     
  Lines         8217    13514     +5297     
  Branches      1368     2148      +780     
============================================
+ Hits             2    11738    +11736     
+ Misses        8215     1420     -6795     
- Partials         0      356      +356     
Flag Coverage Δ
unittests 86.85% <ø> (+86.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/datasets/transforms/compose.py
mmcls/models/backbones/mobilevit.py 91.15% <0.00%> (ø)
mmcls/evaluation/metrics/multi_task.py 94.59% <0.00%> (ø)
mmcls/models/utils/norm.py 80.00% <0.00%> (ø)
mmcls/models/retrievers/image2image.py 91.74% <0.00%> (ø)
mmcls/models/backbones/mvit.py 92.46% <0.00%> (ø)
mmcls/models/backbones/deit3.py 94.52% <0.00%> (ø)
mmcls/models/heads/margin_head.py 89.13% <0.00%> (ø)
mmcls/models/backbones/beit.py 57.06% <0.00%> (ø)
mmcls/models/backbones/levit.py 96.06% <0.00%> (ø)
... and 157 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@okotaku okotaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works. Thank you!

@Ezra-Yu Ezra-Yu changed the title [Fix] Fix retriever multi gpu bug [Fix] Fix retrieval multi gpu bug Feb 9, 2023
@mzr1996 mzr1996 merged commit 705ed2b into open-mmlab:dev-1.x Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants