-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add clip backbone #1258
Conversation
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As inline comments
configs/clip/metafile.yml
Outdated
README: configs/clip/README.md | ||
|
||
Models: | ||
- Name: vit_base_patch16_clip_384.openai_ft_in12k_in1k |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename the model name according to https://mmclassification.readthedocs.io/en/dev-1.x/advanced_guides/convention.html
For example:
clip-vit-base-p16_openai-pre_3rdparty_in1k
clip-vit-base-p16_laion2b-in12k-pre_3rdparty_in1k-384px
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! Thanks for the help.
Changes are applied. |
d21531d
to
f9c9c87
Compare
Codecov ReportBase: 0.02% // Head: 88.65% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev-1.x #1258 +/- ##
============================================
+ Coverage 0.02% 88.65% +88.62%
============================================
Files 121 152 +31
Lines 8217 12127 +3910
Branches 1368 1931 +563
============================================
+ Hits 2 10751 +10749
+ Misses 8215 1064 -7151
- Partials 0 312 +312
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Request for further review. @mzr1996 The directory of converted checkpoints for CLIP model: /mnt/petrelfs/share_data/lirongjie/clip_backbone_ckpt |
952f4e3
to
3bb1919
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please upadte the files according to zerun's comments
Dear Scarecrow0 , |
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Add the CLIP backbone for inference time of Imagenet classification.
BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
Checklist
Before PR:
After PR: