Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reproduce] Update ConvNeXt config files. #1256

Merged
merged 4 commits into from
Dec 19, 2022

Conversation

mzr1996
Copy link
Member

@mzr1996 mzr1996 commented Dec 12, 2022

Motivation

I have reproduced the accuracy of ConvNeXt's tiny, small and base architectures.

Modification

Update all ConvNeXt configs. And since the ConvNeXt-base accuracy is a little lower than the original accuracy (83.66 vs 83.85), I reserved the 3rd party ConvNeXt-base checkpoint.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@mzr1996 mzr1996 requested a review from yingfhu December 12, 2022 03:22
@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Base: 0.02% // Head: 89.17% // Increases project coverage by +89.15% 🎉

Coverage data is based on head (4193b4d) compared to base (b8b31e9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##           dev-1.x    #1256       +/-   ##
============================================
+ Coverage     0.02%   89.17%   +89.15%     
============================================
  Files          121      150       +29     
  Lines         8217    11549     +3332     
  Branches      1368     1850      +482     
============================================
+ Hits             2    10299    +10297     
+ Misses        8215      967     -7248     
- Partials         0      283      +283     
Flag Coverage Δ
unittests 89.17% <ø> (+89.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/datasets/transforms/compose.py
mmcls/evaluation/metrics/voc_multi_label.py 100.00% <0.00%> (ø)
mmcls/models/necks/reduction.py 100.00% <0.00%> (ø)
mmcls/engine/hooks/switch_recipe_hook.py 88.46% <0.00%> (ø)
mmcls/models/backbones/replknet.py 93.00% <0.00%> (ø)
mmcls/engine/hooks/retriever_hooks.py 72.72% <0.00%> (ø)
mmcls/models/backbones/edgenext.py 95.20% <0.00%> (ø)
mmcls/engine/hooks/ema_hook.py 81.69% <0.00%> (ø)
mmcls/models/backbones/efficientformer.py 95.08% <0.00%> (ø)
mmcls/models/classifiers/hugging_face.py 25.64% <0.00%> (ø)
... and 141 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tonysy tonysy mentioned this pull request Dec 12, 2022
@tonysy
Copy link
Collaborator

tonysy commented Dec 12, 2022

#996

Copy link
Collaborator

@yingfhu yingfhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mzr1996 mzr1996 merged commit b635151 into open-mmlab:dev-1.x Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants