-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix import #1255
fix import #1255
Conversation
Codecov ReportBase: 0.02% // Head: 89.16% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## 1.x #1255 +/- ##
==========================================
+ Coverage 0.02% 89.16% +89.14%
==========================================
Files 121 150 +29
Lines 8239 11542 +3303
Branches 1371 1848 +477
==========================================
+ Hits 2 10292 +10290
+ Misses 8237 967 -7270
- Partials 0 283 +283
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
* [Fix] Fix imports in transforms. (#1255) * fix import * import from mmegine.utils * 修复错别字 Co-authored-by: Xieyuan Zhang <25652281+Francis777@users.noreply.github.com>
Dear Francis777, |
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Fix import path.
Modification
This branch is supposed to be compatible with mmcv 2.x, so I corrected the import path, ref in mmcv: https://github.com/Francis777/mmcv/blob/fb39e1e568c49fcd97f9a56cb70a89d6693738c7/mmcv/transforms/__init__.py#L14
Checklist
Before PR:
After PR: