Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix import #1255

Merged
merged 2 commits into from
Dec 19, 2022
Merged

fix import #1255

merged 2 commits into from
Dec 19, 2022

Conversation

Francis777
Copy link
Contributor

@Francis777 Francis777 commented Dec 10, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Fix import path.

Modification

This branch is supposed to be compatible with mmcv 2.x, so I corrected the import path, ref in mmcv: https://github.com/Francis777/mmcv/blob/fb39e1e568c49fcd97f9a56cb70a89d6693738c7/mmcv/transforms/__init__.py#L14

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Dec 10, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Base: 0.02% // Head: 89.16% // Increases project coverage by +89.14% 🎉

Coverage data is based on head (bd1ab04) compared to base (e8284a4).
Patch has no changes to coverable lines.

❗ Current head bd1ab04 differs from pull request most recent head 0d95294. Consider uploading reports for the commit 0d95294 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             1.x    #1255       +/-   ##
==========================================
+ Coverage   0.02%   89.16%   +89.14%     
==========================================
  Files        121      150       +29     
  Lines       8239    11542     +3303     
  Branches    1371     1848      +477     
==========================================
+ Hits           2    10292    +10290     
+ Misses      8237      967     -7270     
- Partials       0      283      +283     
Flag Coverage Δ
unittests 89.16% <ø> (+89.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/datasets/pipelines/auto_augment.py
mmcls/datasets/pipelines/processing.py
mmcls/datasets/pipelines/formatting.py
mmcls/datasets/pipelines/compose.py
mmcls/data/__init__.py
mmcls/datasets/pipelines/__init__.py
mmcls/data/cls_data_sample.py
mmcls/models/backbones/swin_transformer_v2.py 89.63% <0.00%> (ø)
mmcls/engine/optimizers/adan_t.py 10.60% <0.00%> (ø)
mmcls/models/backbones/deit3.py 94.52% <0.00%> (ø)
... and 147 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mzr1996 mzr1996 merged commit e9f9bb2 into open-mmlab:1.x Dec 19, 2022
mzr1996 pushed a commit that referenced this pull request Dec 30, 2022
* [Fix] Fix imports in transforms. (#1255)

* fix import

* import from mmegine.utils

* 修复错别字

Co-authored-by: Xieyuan Zhang <25652281+Francis777@users.noreply.github.com>
@openmmlab-bot
Copy link
Collaborator

Dear Francis777,
First of all, we want to express our gratitude for your significant PR in the MMCls project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.
If you are Chinese or have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. We look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG
Thank you again for your contribution❤
Best regards! @Francis777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants