-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Fix dict update #1234
[Fix] Fix dict update #1234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Codecov ReportBase: 0.02% // Head: 89.02% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev-1.x #1234 +/- ##
============================================
+ Coverage 0.02% 89.02% +88.99%
============================================
Files 121 149 +28
Lines 8217 11458 +3241
Branches 1368 1830 +462
============================================
+ Hits 2 10200 +10198
+ Misses 8215 984 -7231
- Partials 0 274 +274
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mmcls/models/backbones/beit.py
Outdated
attn_cfg.update( | ||
dict( | ||
window_size=window_size, | ||
use_rel_pos_bias=use_rel_pos_bias, | ||
qk_scale=None, | ||
embed_dims=embed_dims, | ||
num_heads=num_heads, | ||
attn_drop=attn_drop_rate, | ||
proj_drop=drop_rate, | ||
bias=bias)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An in-place modification on the mutable default value type should be avoided.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
attn_cfg.update( | |
dict( | |
window_size=window_size, | |
use_rel_pos_bias=use_rel_pos_bias, | |
qk_scale=None, | |
embed_dims=embed_dims, | |
num_heads=num_heads, | |
attn_drop=attn_drop_rate, | |
proj_drop=drop_rate, | |
bias=bias)) | |
attn_cfg = { | |
'window_size': window_size, | |
'use_rel_pos_bias': use_rel_pos_bias, | |
'qk_scale': None, | |
'embed_dims': embed_dims, | |
'num_heads': num_heads, | |
'attn_drop': attn_drop_rate, | |
'proj_drop': drop_rate, | |
'bias': bias, | |
**attn_cfg, | |
} |
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
Checklist
Before PR:
After PR: