Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Update mmcls2torchserve. #1189

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Conversation

austinmw
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Changed mmcv to mmengine

Modification

Updated for 1.x

Checklist

Before PR:

Used github.dev web-based editor to make quick change, hopefully didn't break any linting rules

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Nov 10, 2022

CLA assistant check
All committers have signed the CLA.

@austinmw
Copy link
Contributor Author

austinmw commented Nov 11, 2022

Apologies, changed to #1190

@austinmw austinmw closed this Nov 11, 2022
@Ezra-Yu Ezra-Yu mentioned this pull request Nov 11, 2022
6 tasks
@austinmw austinmw reopened this Nov 11, 2022
@mzr1996 mzr1996 changed the title Update mmcls2torchserve [Fix] Update mmcls2torchserve. Nov 14, 2022
@mzr1996 mzr1996 merged commit ee9ee9c into open-mmlab:dev-1.x Nov 14, 2022
mzr1996 pushed a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants